Skip to content

CLN: 29547 replace old string formatting 7 #31986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

3vts
Copy link
Contributor

@3vts 3vts commented Feb 14, 2020

I splitted PR #31844 in batches, this is the seventh
For this PR I ran the command grep -l -R -e '%s' -e '%d' -e '\.format(' --include=*.{py,pyx} pandas/ and checked all the files that were returned for .format( and changed the old string format for the corresponding fstrings to attempt a full clean of, #29547. I may have missed something so is a good idea to double check just in case

  • [ x ] tests added / passed
  • [ x ] passes black pandas
  • [ x ] passes git diff upstream/master -u -- "*.py" | flake8 --diff

@ShaharNaveh ShaharNaveh added the Code Style Code style, linting, code_checks label Feb 15, 2020
Copy link
Member

@ShaharNaveh ShaharNaveh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@3vts 3vts marked this pull request as ready for review February 15, 2020 14:53
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @3vts lgtm.

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Feb 15, 2020
@WillAyd
Copy link
Member

WillAyd commented Feb 15, 2020

Looks good. Can you merge master?

@simonjayhawkins
Copy link
Member

Looks good. Can you merge master?

no point atm. failing ci.

@simonjayhawkins simonjayhawkins merged commit 45d093d into pandas-dev:master Feb 15, 2020
@simonjayhawkins
Copy link
Member

Thanks @3vts

@3vts 3vts deleted the CLN-29547-Replace-old-string-formatting-7 branch February 21, 2020 01:29
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants